From 71da5b8f68b874d4327508011c1909d7b2d614eb Mon Sep 17 00:00:00 2001 From: sogladev Date: Sun, 19 Oct 2025 19:02:34 +0200 Subject: [PATCH 1/8] fix(DB/Conditions): Krik'thir the Gatewatcher can be hit by Acid Splash (#23301) --- data/sql/updates/pending_db_world/rev_1760816979895001416.sql | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 data/sql/updates/pending_db_world/rev_1760816979895001416.sql diff --git a/data/sql/updates/pending_db_world/rev_1760816979895001416.sql b/data/sql/updates/pending_db_world/rev_1760816979895001416.sql new file mode 100644 index 0000000000..d712a3d86f --- /dev/null +++ b/data/sql/updates/pending_db_world/rev_1760816979895001416.sql @@ -0,0 +1,2 @@ +-- +DELETE FROM `conditions` WHERE (`SourceTypeOrReferenceId` = 13) AND (`SourceGroup` = 1) AND (`SourceEntry` = 52446) AND (`SourceId` = 0) AND (`ElseGroup` = 0) AND (`ConditionTypeOrReference` = 31) AND (`ConditionTarget` = 0) AND (`ConditionValue1` = 3) AND (`ConditionValue2` = 28684) AND (`ConditionValue3` = 0); From d4211fde8d7ad9db33242bcd88f25027d94e46ea Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" Date: Sun, 19 Oct 2025 17:03:45 +0000 Subject: [PATCH 2/8] chore(DB): import pending files Referenced commit(s): 71da5b8f68b874d4327508011c1909d7b2d614eb --- .../rev_1760816979895001416.sql => db_world/2025_10_19_00.sql} | 1 + 1 file changed, 1 insertion(+) rename data/sql/updates/{pending_db_world/rev_1760816979895001416.sql => db_world/2025_10_19_00.sql} (87%) diff --git a/data/sql/updates/pending_db_world/rev_1760816979895001416.sql b/data/sql/updates/db_world/2025_10_19_00.sql similarity index 87% rename from data/sql/updates/pending_db_world/rev_1760816979895001416.sql rename to data/sql/updates/db_world/2025_10_19_00.sql index d712a3d86f..e0749064c1 100644 --- a/data/sql/updates/pending_db_world/rev_1760816979895001416.sql +++ b/data/sql/updates/db_world/2025_10_19_00.sql @@ -1,2 +1,3 @@ +-- DB update 2025_10_18_02 -> 2025_10_19_00 -- DELETE FROM `conditions` WHERE (`SourceTypeOrReferenceId` = 13) AND (`SourceGroup` = 1) AND (`SourceEntry` = 52446) AND (`SourceId` = 0) AND (`ElseGroup` = 0) AND (`ConditionTypeOrReference` = 31) AND (`ConditionTarget` = 0) AND (`ConditionValue1` = 3) AND (`ConditionValue2` = 28684) AND (`ConditionValue3` = 0); From 4670a9a3d5fb45f1d9aafa822042846bf09b7353 Mon Sep 17 00:00:00 2001 From: Luca Folloni Date: Mon, 20 Oct 2025 22:51:32 +0200 Subject: [PATCH 3/8] fix(Scripts/UtigardePinnacle): Skadi the Ruthless is not selectable when in Phase 2 (#23333) --- .../scripts/Northrend/UtgardeKeep/UtgardePinnacle/boss_skadi.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/server/scripts/Northrend/UtgardeKeep/UtgardePinnacle/boss_skadi.cpp b/src/server/scripts/Northrend/UtgardeKeep/UtgardePinnacle/boss_skadi.cpp index cf6318747d..68417705ee 100644 --- a/src/server/scripts/Northrend/UtgardeKeep/UtgardePinnacle/boss_skadi.cpp +++ b/src/server/scripts/Northrend/UtgardeKeep/UtgardePinnacle/boss_skadi.cpp @@ -181,6 +181,7 @@ public: else if (param == ACTION_PHASE2) { SecondPhase = true; + me->RemoveUnitFlag(UNIT_FLAG_NOT_SELECTABLE); events.ScheduleEvent(EVENT_SKADI_CRUSH, 8s); events.ScheduleEvent(EVENT_SKADI_SPEAR, 10s); events.ScheduleEvent(EVENT_SKADI_WHIRLWIND, 15s); From cbfffe8a2e50be8a74d19b32b0a8ff26176bced9 Mon Sep 17 00:00:00 2001 From: Rocco Silipo <108557877+Rorschach91@users.noreply.github.com> Date: Tue, 21 Oct 2025 19:28:49 +0200 Subject: [PATCH 4/8] fix(DB/Creature) Set Unit Flag to Persistence. (#23325) --- data/sql/updates/pending_db_world/Persistence.sql | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 data/sql/updates/pending_db_world/Persistence.sql diff --git a/data/sql/updates/pending_db_world/Persistence.sql b/data/sql/updates/pending_db_world/Persistence.sql new file mode 100644 index 0000000000..60da9b5fc2 --- /dev/null +++ b/data/sql/updates/pending_db_world/Persistence.sql @@ -0,0 +1,3 @@ + +-- Set Unit Flags (Persistence) +UPDATE `creature_template` SET `unit_flags` = `unit_flags` |256|512|33554432 WHERE (`entry` = 29863); From e867443c4ef696e8ee75fe8b027c2f87afeb50ab Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" Date: Tue, 21 Oct 2025 17:29:58 +0000 Subject: [PATCH 5/8] chore(DB): import pending files Referenced commit(s): cbfffe8a2e50be8a74d19b32b0a8ff26176bced9 --- .../Persistence.sql => db_world/2025_10_21_00.sql} | 1 + 1 file changed, 1 insertion(+) rename data/sql/updates/{pending_db_world/Persistence.sql => db_world/2025_10_21_00.sql} (75%) diff --git a/data/sql/updates/pending_db_world/Persistence.sql b/data/sql/updates/db_world/2025_10_21_00.sql similarity index 75% rename from data/sql/updates/pending_db_world/Persistence.sql rename to data/sql/updates/db_world/2025_10_21_00.sql index 60da9b5fc2..c144823029 100644 --- a/data/sql/updates/pending_db_world/Persistence.sql +++ b/data/sql/updates/db_world/2025_10_21_00.sql @@ -1,3 +1,4 @@ +-- DB update 2025_10_19_00 -> 2025_10_21_00 -- Set Unit Flags (Persistence) UPDATE `creature_template` SET `unit_flags` = `unit_flags` |256|512|33554432 WHERE (`entry` = 29863); From f661f57f67ca753228b49c2e6c0d8a6617c4d67c Mon Sep 17 00:00:00 2001 From: Takenbacon Date: Wed, 22 Oct 2025 07:56:54 -0700 Subject: [PATCH 6/8] fix(Core/Visibility): Fix sentry totem visibility not toggling (#23228) --- src/server/game/Entities/Object/Object.cpp | 7 ++----- src/server/game/Entities/Player/Player.h | 1 + 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/src/server/game/Entities/Object/Object.cpp b/src/server/game/Entities/Object/Object.cpp index d39645bb4c..173030d493 100644 --- a/src/server/game/Entities/Object/Object.cpp +++ b/src/server/game/Entities/Object/Object.cpp @@ -1776,6 +1776,8 @@ bool WorldObject::CanSeeOrDetect(WorldObject const* obj, bool ignoreStealth, boo WorldObject const* viewpoint = this; if (Player const* thisPlayer = ToPlayer()) { + viewpoint = thisPlayer->GetSeer(); + if (Creature const* creature = obj->ToCreature()) { if (TempSummon const* tempSummon = creature->ToTempSummon()) @@ -1815,13 +1817,8 @@ bool WorldObject::CanSeeOrDetect(WorldObject const* obj, bool ignoreStealth, boo return false; } - if (thisPlayer->GetViewpoint()) - viewpoint = thisPlayer->GetViewpoint(); - if (thisPlayer->GetFarSightDistance() && !thisPlayer->isInFront(obj)) - { return false; - } } // Xinef: check reversely obj vs viewpoint, object could be a gameObject which overrides _IsWithinDist function to include gameobject size diff --git a/src/server/game/Entities/Player/Player.h b/src/server/game/Entities/Player/Player.h index ef7ca602d9..7154eaa33e 100644 --- a/src/server/game/Entities/Player/Player.h +++ b/src/server/game/Entities/Player/Player.h @@ -2351,6 +2351,7 @@ public: void SetMover(Unit* target); void SetSeer(WorldObject* target) { m_seer = target; } + WorldObject* GetSeer() const { return m_seer; } void SetViewpoint(WorldObject* target, bool apply); [[nodiscard]] WorldObject* GetViewpoint() const; void StopCastingCharm(Aura* except = nullptr); From e8b521b8632e87878192d821eaa5369fcdc44ee0 Mon Sep 17 00:00:00 2001 From: privatecore Date: Wed, 22 Oct 2025 17:22:33 +0200 Subject: [PATCH 7/8] fix(CI/Windows): installer script - update MYSQL version to 8.4.6 (#23348) --- apps/installer/includes/os_configs/windows.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/installer/includes/os_configs/windows.sh b/apps/installer/includes/os_configs/windows.sh index 279b53eaf6..cdba50c27f 100644 --- a/apps/installer/includes/os_configs/windows.sh +++ b/apps/installer/includes/os_configs/windows.sh @@ -26,4 +26,4 @@ choco install -y --skip-checksums "${INSTALL_ARGS[@]}" cmake.install -y --insta choco install -y --skip-checksums "${INSTALL_ARGS[@]}" visualstudio2022-workload-nativedesktop choco install -y --skip-checksums "${INSTALL_ARGS[@]}" openssl --force --version=3.5.4 choco install -y --skip-checksums "${INSTALL_ARGS[@]}" boost-msvc-14.3 --force --version=1.87.0 -choco install -y --skip-checksums "${INSTALL_ARGS[@]}" mysql --force --version=8.4.4 +choco install -y --skip-checksums "${INSTALL_ARGS[@]}" mysql --force --version=8.4.6 From 2a78a1788fe6ce4ff210a1fecf0fe1b434b09d66 Mon Sep 17 00:00:00 2001 From: Localhost <40755539+r0m1ntik@users.noreply.github.com> Date: Wed, 22 Oct 2025 18:49:08 +0200 Subject: [PATCH 8/8] fix(Scripts/EOE): add null check for killer before updating achievement criteria (#23353) Co-authored-by: Roman BADANIN --- .../scripts/Northrend/Nexus/EyeOfEternity/boss_malygos.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/server/scripts/Northrend/Nexus/EyeOfEternity/boss_malygos.cpp b/src/server/scripts/Northrend/Nexus/EyeOfEternity/boss_malygos.cpp index a61e0089c2..6ca80d64f8 100644 --- a/src/server/scripts/Northrend/Nexus/EyeOfEternity/boss_malygos.cpp +++ b/src/server/scripts/Northrend/Nexus/EyeOfEternity/boss_malygos.cpp @@ -1220,8 +1220,9 @@ public: if (Vehicle* v = me->GetVehicle()) v->RemoveAllPassengers(); - if (Player* player = killer->GetCharmerOrOwnerPlayerOrPlayerItself()) - player->UpdateAchievementCriteria(ACHIEVEMENT_CRITERIA_TYPE_GET_KILLING_BLOWS, 1, 0, me); + if (killer) + if (Player* player = killer->GetCharmerOrOwnerPlayerOrPlayerItself()) + player->UpdateAchievementCriteria(ACHIEVEMENT_CRITERIA_TYPE_GET_KILLING_BLOWS, 1, 0, me); } void MoveInLineOfSight(Unit* /*who*/) override {}