fang139842/azerothcore-mirror
1
0
Fork 0
mirror of https://github.com/azerothcore/azerothcore-wotlk.git synced 2025-11-10 20:44:17 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(Core/Player): Only mark spells as invalid when none of the Skills match (#22537)

Browse Source
This commit is contained in:
Tereneckla 2025-07-23 15:49:29 +00:00 committed by GitHub
parent 6bf8469cf3
commit a96c7e85c5
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 12 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/server/game/Entities/Player/Player.cpp
View File

@ -3104,22 +3104,26 @@ bool Player::addSpell(uint32 spellId, uint8 addSpecMask, bool updateActive, bool
bool Player::CheckSkillLearnedBySpell(uint32 spellId)
{
SkillLineAbilityMapBounds skill_bounds = sSpellMgr->GetSkillLineAbilityMapBounds(spellId);
uint32 errorSkill = 0;
for (SkillLineAbilityMap::const_iterator sla = skill_bounds.first; sla != skill_bounds.second; ++sla)
{
SkillLineEntry const* pSkill = sSkillLineStore.LookupEntry(sla->second->SkillLine);
if (!pSkill)
continue;
SkillRaceClassInfoEntry const* rcEntry = GetSkillRaceClassInfo(pSkill->id, getRace(), getClass());
if (!rcEntry)
{
LOG_ERROR("entities.player", "Player {} (GUID: {}), has spell ({}) that teach skill ({}) which is invalid for the race/class combination (Race: {}, Class: {}). Will be deleted.",
GetName(), GetGUID().GetCounter(), spellId, pSkill->id, getRace(), getClass());
return false;
}
if (GetSkillRaceClassInfo(pSkill->id, getRace(), getClass()))
return true;
else
errorSkill = pSkill->id;
}
if (errorSkill)
{
LOG_ERROR("entities.player", "Player {} (GUID: {}), has spell ({}) that teach skill ({}) which is invalid for the race/class combination (Race: {}, Class: {}). Will be deleted.",
GetName(), GetGUID().GetCounter(), spellId, errorSkill, getRace(), getClass());
return false;
}
return true;
}